Normalize and add error messages for unterminated literals #5409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RX14
approved these changes
Dec 19, 2017
jhass
approved these changes
Dec 19, 2017
|
Look at circleCI: this actually broke the build but broke it in a way where it exited 0. Please fix the compiler specs! |
|
I'll fix the missing specs. But how is it possible that it exits with |
|
@straight-shoota we should probably exit with an error code if any |
|
Also, I can't reproduce the |
straight-shoota
added a commit
to straight-shoota/crystal
that referenced
this pull request
Dec 19, 2017
straight-shoota
added a commit
to straight-shoota/crystal
that referenced
this pull request
Dec 19, 2017
jhass
pushed a commit
that referenced
this pull request
Dec 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR normalizes error messages for unterminated literals to start with an uppercase letter and use a lower case letter for the literal type. It also fixes reported literal type which was previously
stringfor any percent literal. It adds some specs for several literals.