Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to work formatting foo.[bar] = baz #5424

Merged
merged 1 commit into from
Jan 10, 2018
Merged

Fix to work formatting foo.[bar] = baz #5424

merged 1 commit into from
Jan 10, 2018

Conversation

makenowjust
Copy link
Contributor

Fixed #5416

@RX14
Copy link
Contributor

RX14 commented Dec 21, 2017

I'm not sure we should allow reciever.[foo] = bar. Is there any reason not to enforce reciever[foo] = bar? I assume they're the exact same thing.

@makenowjust
Copy link
Contributor Author

makenowjust commented Dec 21, 2017 •
edited
Loading

We should allow this because it is needed to write an assignment with multiline call chaining:

foo
  .bar_method(...)
  .baz_method(...)
  .[foobar] = baz

And also we can't enforce foo[bar] = baz always for this reason.

RX14
RX14 approved these changes Dec 21, 2017
View reviewed changes
Copy link
Contributor

@RX14 RX14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks

asterite
asterite approved these changes Jan 10, 2018
View reviewed changes
Copy link
Member

@asterite asterite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! But it needs a rebase.

@makenowjust makenowjust force-pushed the fix/crystal-format/work-dot-bracket-equal branch from 6c503f9 to 4702bd8 Compare January 10, 2018 14:23
@makenowjust
Copy link
Contributor Author

rebased

@makenowjust makenowjust force-pushed the fix/crystal-format/work-dot-bracket-equal branch from 4702bd8 to f9483c2 Compare January 10, 2018 14:31
@asterite asterite merged commit 972f2b3 into crystal-lang:master Jan 10, 2018
@asterite asterite added this to the Next milestone Jan 10, 2018
@asterite asterite added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:tools:formatter labels Jan 10, 2018
@makenowjust makenowjust deleted the fix/crystal-format/work-dot-bracket-equal branch January 10, 2018 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codenoid codenoid codenoid approved these changes

@RX14 RX14 RX14 approved these changes

@asterite asterite asterite approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:tools:formatter
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.
4 participants
@makenowjust @RX14 @asterite @codenoid