Rename 'failed' to 'failures' in junit output. #5463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The junit formatter output contains the 'failed' attribute on the testsuite node, which must be called 'failures'.
RX14
approved these changes
Dec 28, 2017
RX14
added
kind:bug
asterite
approved these changes
Jan 2, 2018
|
I think junit output should be a shard, not in the standard library. |
|
@asterite at the least it should be optional. At one point I wanted to use junit output in Jenkins for the stdlib specs, which would be... tricky if it were a shard at least. Probably not going to go that route now if I ever get around to custom CI... |
lukeasrodgers
pushed a commit
to lukeasrodgers/crystal
that referenced
this pull request
Jan 7, 2018
The junit formatter output contains the 'failed' attribute on the testsuite node, which must be called 'failures'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The junit formatter output contains the 'failed' attribute
on the testsuite node, which must be called 'failures'. Closes #5462