Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly stub out Exception#backtrace? #5622

Merged
merged 1 commit into from
Jan 24, 2018
Merged

Correctly stub out Exception#backtrace? #5622

merged 1 commit into from
Jan 24, 2018

Conversation

RX14
Copy link
Contributor

@RX14 RX14 commented Jan 21, 2018

Previously, this would mean Exception#backtrace raised, now it just returns an empty backtrace.

@RX14 RX14 added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib platform:windows Windows support based on the MSVC toolchain / Win32 API labels Jan 21, 2018
@RX14 RX14 mentioned this pull request Jan 21, 2018
Open
22 tasks
@RX14
Copy link
Contributor Author

RX14 commented Jan 24, 2018

Surely we can get this merged?

@asterite asterite merged commit 302ff6c into crystal-lang:master Jan 24, 2018
@RX14 RX14 added this to the Next milestone Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asterite asterite asterite approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. platform:windows Windows support based on the MSVC toolchain / Win32 API topic:stdlib
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.
2 participants
@RX14 @asterite