-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't use heredoc inside interpolation #5648
Don't use heredoc inside interpolation #5648
Conversation
fd21faf
to
697043e
Compare
ping @asterite. Could you review this? |
@makenowjust no, sorry, I won't have time to review PRs related to the compiler. I'll just discuss issues and approve trivial PRs |
Maybe rebase? to make sure it still works who knows... |
697043e
to
adacab6
Compare
heredoc inside interpolation is buggy and it is unuseful. It is a bit hard to fix this, so I'd like to forbid.
adacab6
to
b1dd55e
Compare
@RX14 I think this failed is irrelevant. Could you re-run CircleCI job? |
Thank you. |
@makenowjust just to clarify, is this a breaking change or not? (i.e. did this work before or is this just improving the error message) |
@RX14 Just a bug fix (or bug hiding). There is no source code broken by this. |
A heredoc inside interpolation is buggy. For example, this code cannot be compiled even though it was valid Ruby code:
And this code is compiled even though it was invalid Ruby code:
I tried to fix these, however I did't complete it and I found it is a bit hard to fix.
A heredoc inside interpolation is very tricky, so I suggest forbidding this.
Thank you.