Fix spawn macro for call with receiver
#5781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RX14
approved these changes
Mar 6, 2018
RX14
added
kind:bug
bew
reviewed
Mar 6, 2018
| @@ -41,4 +41,8 @@ describe "concurrent" do | |||
| spawn method_named("foo"), name: "foo" | |||
| Fiber.yield | |||
| end | |||
|
|
|||
| it "accepts method call with receiver" do | |||
| typeof(spawn String.new) | |||
There was a problem hiding this comment.
Maybe do something real in the spec?
There was a problem hiding this comment.
I don't think there's a need for an elaborate test, the basic functionality is already tested. This spec is just to ensure the macro produces valid code.
jhass
approved these changes
Mar 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spawn String.newexpands to (simplified)spawn { new }because thespawnmacro only writes{{ call.name }}and not the receiver.This PR fixes this by prepending
{% if call.receiver %}{{ call.receiver }}.{% end %}.