IO#write: return early if slice is empty #6269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RX14
reviewed
Jun 26, 2018
| @@ -14,13 +14,14 @@ module Crystal::System::FileDescriptor | |||
|
|
|||
| private def unbuffered_write(slice : Bytes) | |||
| loop do | |||
| return if slice.empty? | |||
asterite
force-pushed
the
feature/6268-openssl-socket-write-empty-slice
branch
from
dbafeac to
46cec0e
Compare
Sija
reviewed
Jun 26, 2018
| wait_writable | ||
| return if slice.empty? | ||
|
|
||
| begin |
There was a problem hiding this comment.
Because the ensure must not run if the slice is empty. It's pointless to do anything at all if the slice is empty.
There was a problem hiding this comment.
Yeah, I meant that ensure could be attached to the loop instead, like it was before.
There was a problem hiding this comment.
It was attached to the def
RX14
approved these changes
Jun 26, 2018
RX14
added
kind:bug
jhass
approved these changes
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6268
Writing an empty slice should do nothing, so this PR adds this check to return early in that case. Fixes that case for OpenSSL socket, but also for others (no tests included because it's a bit hard to test, but the change isn't that complex).