-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove :nodoc: from singular method aliases, add Int#microsecond alias #6297
Conversation
@Sija do you realize this aliases are only one character different? |
@j8r It's about being able to write |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ditto
descriptions are bad.
The generated API docs sorts methods alphabetically.
Therefore we will have:
#ago
, which has a proper description#day
, which haveditto
as a description#days
, which has a proper description.
I don't see better descriptions than "Like #days
but without an s
" , which is bad 😶
The same applies with the other methods.
@j8r |
Sorry @asterite this wasn't as clear as |
Yeah I considered that, but it's such a minor change that it's really not worth breaking. |
|
Just needs review |
We can use a single macros to add all this non {% for time in %w(nanosecond microsecond millisecond second minute hour day week month year) %}
# Returns a `Time::Span` of `self` {{time.id}}s.
def {{time.id}} : Time::Span
{{time.id}}s
end
{% end %} |
Can this go forward? |
Refs #6273