-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace mapping with serializable in compiler #6308
replace mapping with serializable in compiler #6308
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of these are structs - can some of the properties be getter
s instead?
travis crashed with getters:
|
This reverts commit 0ca97ce.
Just use getters where no setters are needed. You don't have to wait for travis if you run the specs locally. |
i don't know how it used and where, with mapping it all was as property. |
Well, it's just six ivars and you already know one needs a setter. Just trial and error will get you through very quickly. |
But what's the problem? They were properties before. I'd say that can be "fixed" in another PR... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @kostya 👍
Next we should remove mapping. |
No description provided.