-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flatten project structure created by crystal init #6317
Flatten project structure created by crystal init #6317
Conversation
`crystal init` previously created `src/example/version.cr` file which only contained a `VERSION` constant. This is moved into the main library file, The old `version.cr` convention persisted from ruby due to the need for gemspec files to require only the version constant from the library.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to put everything under src
, not the artificial src/foo
folder inherited from rubygem. I'm all in for this evolution.
I cant 👍 @ysbaddaden comment but I agree. |
put everything in src produce much more require conflicts, as src is a search path in crystal. |
@kostya What? |
@kostya no, this conflict only happens in Rubygem, which adds each gem |
I agree with @RX14 opinion, Is there have a better solve to combine |
crystal init
previously createdsrc/example/version.cr
file which only contained aVERSION
constant. This is moved into the main library file. It also removesrequire "./example/*"
from main file.The old
version.cr
convention persisted from Ruby due to the need for gemspec files to require only the version constant from the library.Extracted from #5428 to make this easier to merge with (hopfully) less discussion and we can focus there (or in a new issue) on the value of
VERSION
. @RX14 I hope you don't mind 😉#5428 (comment)