Encoding: compare with case insensitive UTF-8 to avoid using iconv when not necessary #6355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asterite
force-pushed
the
feature/dont-use-iconv-for-case-insensitive-utf8
branch
2 times, most recently
from
5c29c3d to
b215bbc
Compare
ysbaddaden
approved these changes
Jul 8, 2018
|
Do we want to allow |
RX14
approved these changes
Jul 8, 2018
|
@jhass Maybe, I'll later check if that's valid for iconv. |
|
I don't think it is - at least it's behind a |
|
Oh - Seems libiconv isn't used and iconv is built into the glibc. |
…iconv when not necessary
asterite
force-pushed
the
feature/dont-use-iconv-for-case-insensitive-utf8
branch
from
b215bbc to
c331845
Compare
|
Updated to check against "UTF-8" and "UTF8" |
RX14
approved these changes
Jul 8, 2018
RX14
added
kind:bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have
IO#set_encodingwhich accepts an encoding. If it's UTF-8 there's nothing to do, because IO is assumed to be UTF-8 by default (regarding text). The current comparison is case sensitive, but in some cases the encoding can come with other cases (like in #6353). So to avoid using iconv, which should be slower then just doing it in Crystal (and also a bit redundant), I added a case insensitive comparison.Update: includes tests.