Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dir.glob to list broken symlinks #6466

Merged
merged 1 commit into from
Aug 1, 2018
Merged

Fix Dir.glob to list broken symlinks #6466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions spec/std/dir_spec.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,7 @@ describe "Dir" do
datapath("f1_link.txt"),
datapath("non_link.txt"),
].sort
Dir["#{datapath}/non_link.txt"].should eq [datapath("non_link.txt")]
ensure
File.delete link
File.delete non_link
Expand Down
2 changes: 1 addition & 1 deletion src/dir/glob.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ class Dir
when ConstantEntry
return if sequence[pos + 1]?.is_a?(RecursiveDirectories)
full = join(path, cmd.path)
yield full if File.exists?(full)
yield full if File.exists?(full) || File.symlink?(full)
when ConstantDirectory
path_stack << {next_pos, join(path, cmd.path)}
# Don't check if full exists. It just costs us time
Expand Down