Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove {% if properties.size > 0 %} conditions #6539

Merged
merged 1 commit into from
Aug 28, 2018
Merged

Remove {% if properties.size > 0 %} conditions #6539

merged 1 commit into from
Aug 28, 2018

Conversation

wooster0
Copy link
Contributor

Since #6367 {% if properties.size > 0 %} conditions aren't needed anymore.

@wooster0
Copy link
Contributor Author

Oh I forgot CI is still using 0.25.1.

sdogruyol
sdogruyol approved these changes Aug 28, 2018
View reviewed changes
Copy link
Member

@sdogruyol sdogruyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @r00ster91 👍

@sdogruyol sdogruyol merged commit 1ce6f4d into crystal-lang:master Aug 28, 2018
@sdogruyol sdogruyol added this to the 0.27.0 milestone Aug 28, 2018
ezrast pushed a commit to ezrast/crystal that referenced this pull request Oct 2, 2018
@wooster0
Remove {% if properties.size > 0 %} conditions (crystal-lang#6539)
4a30e24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RX14 RX14 RX14 approved these changes

@sdogruyol sdogruyol sdogruyol approved these changes

Assignees
No one assigned
Labels
kind:refactor topic:stdlib
Projects
None yet
Milestone
0.27.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wooster0 @sdogruyol @RX14 @bcardiff