Avoid using Comparable(self) in reference types #6549
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcardiff
added
the
kind:bug
|
I like this change anyway because it is more explicit. |
jhass
approved these changes
Aug 17, 2018
sdogruyol
approved these changes
Aug 17, 2018
|
FYI, related discussion in #3972 (comment) that leads to revert the lazy evaluation of self. |
|
With #6557 merges this can be closed actually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6547.
This is a workaround fix.
There seems to be an issue with type guessed ivars and generics and self that I'm trying to narrow it down. But maybe it also involves macros that lucky quite much since I wasn't able to frame it yet.
Meanwhile this PR removes
include Comparable(self)from reference types (leaving it only in Enum and some specs).