Restore #bind_ssl as deprecated api #6551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
approved these changes
Aug 16, 2018
RX14
reviewed
Aug 17, 2018
| @@ -258,6 +258,11 @@ class HTTP::Server | |||
| def bind_tls(address : Socket::IPAddress, context : OpenSSL::SSL::Context::Server) : Socket::IPAddress | |||
| bind_tls(address.address, address.port, context) | |||
| end | |||
|
|
|||
| # DEPRECATED: Use `#bind_tls`. | |||
There was a problem hiding this comment.
Please add an explicit TODO: remove in 0.27.0 or similar
we should probably eventually settle on a TODO(0.27.0) style with a grep -R "TODO($(crystal -v))" src spec to fail the build. when you upgrade the compiler.
Which also reminds me that there should be a crystal -v which is machine-readable not human-readable....
RX14
approved these changes
Aug 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restores
HTTP::Server#bind_sslremoved by #6533 so the current master can be used to ship 0.26.1 without breaking changes.HTTP::Server#bind_sslcan be removed in 0.27