Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting empty heredoc #6567

Merged

Conversation

makenowjust
Copy link
Contributor

Fixed #6564

# If the delimiter ends with '\n' it's something like "\n HEREDOC",
# so we are done
break if @token.raw.starts_with?('\n')
# Heredoc cannot contain string continutation,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: continutation => continuation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

Thank you @j8r!
@bcardiff bcardiff added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:tools:formatter labels Aug 20, 2018
@bcardiff bcardiff added this to the 0.26.1 milestone Aug 20, 2018
@RX14 RX14 merged commit d9d345f into crystal-lang:master Aug 20, 2018
@makenowjust makenowjust deleted the fix/crystal-format/6564-empty-heredoc branch August 20, 2018 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:tools:formatter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants