Use blocking IO on a TTY if it can't be reopened #6660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably cleaner to do path = uninitialized UInt8[256]
ret = LibC.ttyname_r(fd, path, 256)
return new(fd: blocking: true) unless ret == 0
clone_fd = LibC.open(path, LibC::O_RDWR)
return new(fd: blocking: true) if clone_fd == -1
new(clone_fd).tap(&.close_on_exec = true) |
|
@RX14 Your example calls are missing |
ysbaddaden
approved these changes
Sep 5, 2018
RX14
approved these changes
Sep 5, 2018
RX14
added
kind:bug
RX14
pushed a commit
to RX14/crystal
that referenced
this pull request
Sep 10, 2018
* Use blocking IO on a TTY if it can't be reopened * Simplify tty fallback logic
ezrast
pushed a commit
to ezrast/crystal
that referenced
this pull request
Oct 2, 2018
* Use blocking IO on a TTY if it can't be reopened * Simplify tty fallback logic
|
This pull request has been mentioned on Crystal Forum. There might be relevant details there: https://forum.crystal-lang.org/t/unable-to-get-info-bad-file-descriptor-io-error/6820/16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix issue #6624
Kinda hard to test though. Doesn't seem to have any regressions at least.