Fix spec for Time::Location.load_local with TZ=nil #6740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RX14
approved these changes
Sep 17, 2018
sdogruyol
approved these changes
Sep 18, 2018
There was a problem hiding this comment.
CircleCI failures seems to be on their side. Thank you @straight-shoota 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On POSIX systems, if environment variable
TZis not set,Time::Location.load_locallooks up the time zone setting in/etc/localtime. However, if this file is not available (or invalid), the default valueUTCis used.That breaks the spec, which assumes the return value to be always
Local.This is an issue when
/etc/localtimeis not populated by default which makes it depend on OS configuration.The FreeBSD port contains a patch to disable this spec because it would fail on a clean install without time zone configured.
I changed the spec to pass when the returned location name is either
LocalorUTC.