Switch order of "xmlns" and prefix in XML::Builder#namespace #6743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariakimheinert
changed the title
mariakimheinert
changed the title
mariakimheinert
force-pushed
the
bug/namespace-decl-order
branch
from
243a95c to
ba5ed59
Compare
RX14
approved these changes
Sep 18, 2018
bcardiff
approved these changes
Sep 18, 2018
bcardiff
added
kind:bug
ezrast
pushed a commit
to ezrast/crystal
that referenced
this pull request
Oct 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed order of
"xmlns"andprefixinXML::Builder#namespaceso that the function produces a valid namespace declaration of the formxmlns:prefix="URI"(https://www.w3schools.com/xml/xml_namespaces.asp), rather thanprefix:xmlns="URI".