Improve sprintf docs, minor String::Formatter refactors #6758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/kernel.cr
Outdated
| @@ -73,7 +73,7 @@ end | |||
| # The syntax for a format specifier is: | |||
| # | |||
| # ```text | |||
| # %[flags][width][.precision]type | |||
| # %[flags][width][.precision][type] | |||
There was a problem hiding this comment.
What? The type is required. That's why it is not in brackets.
There was a problem hiding this comment.
Oh I didn't realize the brackets indicate that the argument is optional.
bew
reviewed
Sep 20, 2018
src/string/formatter.cr
Outdated
| @@ -110,7 +110,7 @@ struct String::Formatter(A) | |||
|
|
|||
| private def consume_width(flags) | |||
| case current_char | |||
| when '1'..'9' | |||
| when '0'..'9' | |||
There was a problem hiding this comment.
I think this is wrong, unless the 0 is after a non-0 digit, 0 is a separate flag:
Line 150 in 3917852
(I can't fully check the implementation, i'm on my phone)
RX14
approved these changes
Oct 10, 2018
sdogruyol
added
kind:bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes redundant spaces in the
sprintfdocumentation. The spaces have just been copied from Ruby'ssprintf.c. They are there because Ruby uses the 4-space-code-markdown but in Crystal that's not required because Crystal uses the ```-markdown.And this also adds the missing
cformat flag. It's documented but not actually implemented.