Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dead links in docs of Enumerable#chunks and Iterator#chunk #6941

Merged
merged 3 commits into from
Dec 31, 2018

Conversation

wooster0
Copy link
Contributor

Clicking on Enumerable::Chunk::Drop or ::Alone leads to https://crystal-lang.org/api/0.26.1/Enumerable/Chunk/Drop.html which leads to https://crystal-lang.org/404 because Enumerable::Chunk is :nodoc:.

@Sija
Copy link
Contributor

Sija commented Oct 14, 2018

Removing docs because of that doesn't seem like a solution. Perhaps it would be better to remove :nodoc from Enumerable::Chunk instead.

@straight-shoota
Copy link
Member

@r00ster91 Could you add a short description to each of the now expose types? A reference to Enumerable#chunks should suffice.

@straight-shoota straight-shoota merged commit 3dffcce into crystal-lang:master Dec 31, 2018
@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. kind:docs labels Dec 31, 2018
@straight-shoota straight-shoota added this to the 0.27.1 milestone Dec 31, 2018
@bcardiff bcardiff added topic:stdlib:collection and removed kind:bug A bug in the code. Does not apply to documentation, specs, etc. labels Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants