Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Contributors section of README template #7005

Merged
merged 2 commits into from
Oct 30, 2018

Conversation

wooster0
Copy link
Contributor

What if for example your name is username and your GitHub username is username too? Then this is what you would get from generating a template: (when you also replace the your-github-user accordingly)

  • username username - creator, maintainer

This looks strange and quite confusing in my opinion.

But now with this PR, for the link name, the name is used which the user gave himself here in the settings:

grafik

When the user explicty entered his nickname or real name there, he likely wants this name to show up. Instead of both the GitHub username and the name. It's shorter and simple.

And for the link itself, the GitHub username is of course still used.

And for the "creator, maintainer" I don't see a reason to not make it 3 characters longer and use "and". Sounds better IMO.

So now the Contributors section would simply look like this:


Contributors

Copy link
Member

@sdogruyol sdogruyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @r00ster91 👍

@sdogruyol sdogruyol merged commit 91c0938 into crystal-lang:master Oct 30, 2018
@sdogruyol sdogruyol added this to the 0.27.0 milestone Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants