Improve Contributors section of README template #7005
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What if for example your name is
username
and your GitHub username isusername
too? Then this is what you would get from generating a template: (when you also replace theyour-github-user
accordingly)This looks strange and quite confusing in my opinion.
But now with this PR, for the link name, the name is used which the user gave himself here in the settings:
When the user explicty entered his nickname or real name there, he likely wants this name to show up. Instead of both the GitHub username and the name. It's shorter and simple.
And for the link itself, the GitHub username is of course still used.
And for the "creator, maintainer" I don't see a reason to not make it 3 characters longer and use "and". Sounds better IMO.
So now the Contributors section would simply look like this:
Contributors