Fix #unix_ms to #to_unix_ms in CANGELOG.md
#7024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CHANGELOG for 0.27.0 shows that some instance method names are changed in Time class. > - **(breaking-change)** Rename `Time#epoch` to `Time#to_unix`. Also `#epoch_ms` to `#to_unix_ms`, and `#epoch_f` to `#to_unix_f`. ([#6662](#6662), thanks @straight-shoota) Actually, `#epoch_ms` was renamed to `#to_unix_ms`, not `#unix_ms`.
straight-shoota
approved these changes
Nov 5, 2018
sdogruyol
approved these changes
Nov 5, 2018
|
@arcage little typo, |
|
@j8r Oops, sorry. I've tried to correct the commit title. Is this OK? Or, should I close this PR and reopen with correct commit title? |
|
This is fine 👍 |
|
It'll be rebased, the commit title & message can be edited. |
RX14
approved these changes
Nov 7, 2018
RX14
added
the
kind:bug
bcardiff
added
kind:docs
and removed
kind:bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CHANGELOG of the 0.27.0 shows that some instance method names are changed in Time class.
Actually,
#epoch_mswas renamed to#to_unix_ms, not#unix_ms.