Replace inappropriate uses of Time.now
#7155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The time value is converted to Unix time anyway, so there is no point in assigning a time zone.
It will be transmitted as UTC time anyway, so there is no point in assigning a time zone.
asterite
reviewed
Dec 6, 2018
jhass
approved these changes
Dec 6, 2018
|
@asterite Sure, the method body of start = Time.monotonic
do_stuff
elapsed = Time.monotonic - startThis would be closer to the previous usage of I'd prefer to use |
|
@asterite really? |
asterite
requested changes
Dec 7, 2018
samples/red_black_tree.cr
Outdated
| res = yield | ||
| elapsed = Time.measure do | ||
| print "#{name}: " | ||
| res = nil |
There was a problem hiding this comment.
This line is not needed.
This is why I don't like the block form of measure, it forces you to adjust your code (variables inside the block will not be seen outside it).
|
@ysbaddaden Yes. Because it's a block it forces you to declare some variables outside of it, as in my comment above. The other form is less obtrusive. |
|
OK, I understand. |
wooster0
reviewed
Dec 8, 2018
| @@ -384,24 +384,26 @@ class RedBlackTreeRunner | |||
| end | |||
|
|
|||
| def bench(name, n = 1) | |||
| t = Time.now | |||
There was a problem hiding this comment.
The changes to this file are actually already done in #6454, samples/red_black_tree.cr.
asterite
approved these changes
Dec 9, 2018
RX14
approved these changes
Dec 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For measuring elapsed time,
Time.measureshould be used. In applications, where a time zone won't be used anyway, it's better to useTime.utc_nowinstead ofTime.nowto avoid loading a time zone which can be expensive (loading from disk) when it is completely unnecessary.