Fix 'NamedTupleLiteral#[]` to raise an error for invalid key type #7158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And also update doc.
Sija
reviewed
Dec 7, 2018
| @@ -937,7 +937,7 @@ module Crystal | |||
| when StringLiteral | |||
| key = key.value | |||
| else | |||
| return NilLiteral.new | |||
| raise "argument to [] must be a symbol or string, not #{key.class_desc}:\n\n#{key}" | |||
There was a problem hiding this comment.
I'd suggest avoiding newlines in exception messages if possible.
RX14
approved these changes
Dec 7, 2018
|
I don't think this is right. With this, there's no way to know whether a key is present or not in the named tuple literal. |
|
Guess we need |
|
Maybe. Or just returning |
|
AFAIK this exception is raised only when a wrong type of node passed as a key, value can still be |
|
@Sija oh, right, I looked too quickly. Thanks! |
asterite
approved these changes
Dec 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #7153
And also update doc.
NamedTupleLiteral#[]=denies key typed neitherStringLiteral,SymbolLiteralnorMacroIdalready. I thinkNamedTuple#[]should do same.