Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean SemanticVersion for better performance #7234

Merged
merged 1 commit into from
Dec 29, 2018
Merged

Clean SemanticVersion for better performance #7234

merged 1 commit into from
Dec 29, 2018

Conversation

j8r
Copy link
Contributor

@j8r j8r commented Dec 29, 2018

I've noticed minor improvements that can be done in SemanticVersion here and there.
Changed to a struct because it's immutable.

@RX14 RX14 added this to the 0.27.1 milestone Dec 29, 2018
@RX14 RX14 merged commit a2a319f into crystal-lang:master Dec 29, 2018
@j8r j8r deleted the semantic-version-optimization branch December 29, 2018 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RX14 RX14 RX14 approved these changes

@asterite asterite asterite approved these changes

Assignees
No one assigned
Labels
kind:refactor performance topic:stdlib
Projects
None yet
Milestone
0.27.1
Development

Successfully merging this pull request may close these issues.
4 participants
@j8r @asterite @RX14 @bcardiff