-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor coloring in compiler #7252
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sija
reviewed
Jan 2, 2019
wooster0
force-pushed
the
color
branch
2 times, most recently
from
January 3, 2019 11:28
c6c178c
to
06ca67f
Compare
Phew CI finally passes! That took way too long. |
Sija
reviewed
Jan 3, 2019
j8r
reviewed
Jan 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This:
Originally I just wanted to fix that when you do
''
, that the did-you-mean in the error is colored in bold yellow (currently it's not) but it turned out to be actually quite difficult to retrieve the@color
value from theCompiler
(whether--no-color
has been passed or not) from this spot in the lexer.So now at the beginning of a compilation,
Colorize.enabled
is simply used to turn colors off when--no-color
has been passed. Which is much simpler than having to define acolorize
method first and then having to figure out how to even retrieve thecolor
value from the compiler. Now strings can be colored wherever you want just like you would in your own code withoutcolorize
helper methods."colorize"
requires.Time.new(seconds: 0)
results in the errorwith the last item not being colored in bold/white (or more specifically with the items after the
(trying this one)
not being colored in bold/white). That's fixed as well.