Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compiler: Restore usage of embedded default_target_triple #7317

Merged
merged 1 commit into from
Jan 17, 2019
Merged

Compiler: Restore usage of embedded default_target_triple #7317

merged 1 commit into from
Jan 17, 2019

Conversation

bcardiff
Copy link
Member

Fix #7289

@bcardiff bcardiff added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler labels Jan 17, 2019
@bcardiff bcardiff added this to the 0.27.1 milestone Jan 17, 2019
@bcardiff bcardiff requested a review from RX14 January 17, 2019 15:29
ysbaddaden
ysbaddaden approved these changes Jan 17, 2019
View reviewed changes
Copy link
Contributor

@ysbaddaden ysbaddaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. That was actually the opposite of what I thought.

@bcardiff
Copy link
Member Author

Crystal::Codegen::Target is initialized in more than one place. And since it's not in a LLVM namespace I feel comfortable changing the initial value to depend on Crystal::Config.default_target_triple and not LLVM.default_target_triple

RX14
RX14 approved these changes Jan 17, 2019
View reviewed changes
Copy link
Contributor

@RX14 RX14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch

@RX14 RX14 merged commit c20d02c into crystal-lang:master Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RX14 RX14 RX14 approved these changes

@ysbaddaden ysbaddaden ysbaddaden approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler
Projects
None yet
Milestone
0.27.1
Development

Successfully merging this pull request may close these issues.
3 participants
@bcardiff @ysbaddaden @RX14