Fix: integer overflow in main thread stack base detection #7373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysbaddaden
added
the
kind:bug
Sija
reviewed
Feb 4, 2019
ysbaddaden
force-pushed
the
fix/overflow-error-in-main-fiber-stack-base-detection
branch
from
dad6042 to
0da2b62
Compare
bcardiff
reviewed
Feb 4, 2019
bcardiff
reviewed
Feb 4, 2019
Using `getrlimit` led to invalid STACK SIZE limits in some cases which in turn led to an integer overflow while detecting the stack base of the main stack. This patch replaces `getrlimit` with proper, but non portable, calls to pthread functions that return the stack of a given thread. fixes crystal-lang#7368 fixes crystal-lang#7369
ysbaddaden
force-pushed
the
fix/overflow-error-in-main-fiber-stack-base-detection
branch
from
0da2b62 to
e394c64
Compare
|
CI should pass now 🤞 |
|
Manually checked in macOS & FreeBSD. |
bcardiff
approved these changes
Feb 4, 2019
|
Thanks @ysbaddaden 💯 👑 |
|
Presumably this will require a new release? |
|
Yes @oprypin we will release 0.27.2 tomorrow probably with the fixed indicated in that milestone. |
ysbaddaden
deleted the
fix/overflow-error-in-main-fiber-stack-base-detection
branch
bcardiff
pushed a commit
that referenced
this pull request
Feb 4, 2019
Using `getrlimit` led to invalid STACK SIZE limits in some cases which in turn led to an integer overflow while detecting the stack base of the main stack. This patch replaces `getrlimit` with proper, but non portable, calls to pthread functions that return the stack of a given thread. fixes #7368 fixes #7369
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
getrlimitled to invalid STACK SIZE limits in some cases which in turn led to an integer overflow while detecting the stack base of the main stack. This patch replacesgetrlimitwith proper, but non portable, calls to pthread functions that return the stack of a given thread.Note: only tested on x86_64-linux-gnu. I didn't test on macOS, FreeBSD or OpenBSD.
fixes #7368
fixes #7369