Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the font-weight used in Playground #7552

Merged
merged 1 commit into from
Mar 18, 2019
Merged

Change the font-weight used in Playground #7552

merged 1 commit into from
Mar 18, 2019

Conversation

Maroo-b
Copy link
Contributor

@Maroo-b Maroo-b commented Mar 14, 2019

  • Use Normal weight-font for better readability.

This simple PR addresses the following issue: #6753

@Maroo-b
Change the font-weight used in Playground
10ec5dc 
- Use Normal weight-font for better readability.
bcardiff
bcardiff approved these changes Mar 15, 2019
View reviewed changes
Copy link
Member

@bcardiff bcardiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will miss the light fonts, but a11y ftw 😃

@Maroo-b
Copy link
Contributor Author

Maroo-b commented Mar 15, 2019

@bcardiff thank you for the quick feedback :)

I noticed that recent PRs incuding my simple PR are having a failing spec with darwin build link

Is it normal or does it require some investigation?

@bcardiff
Copy link
Member

@Maroo-b yes it was due to #7548. If you rebase on master the specs will pass now. Although this PR does not affect them so it is not really necessary.

We just need one more approval to merge this.

@Maroo-b
Copy link
Contributor Author

Maroo-b commented Mar 15, 2019

@bcardiff that's good to know, then I will pick another newcomer issue :)

sdogruyol
sdogruyol approved these changes Mar 18, 2019
View reviewed changes
Copy link
Member

@sdogruyol sdogruyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Maroo-b 👍

@sdogruyol sdogruyol merged commit 076b518 into crystal-lang:master Mar 18, 2019
@sdogruyol sdogruyol added this to the 0.28.0 milestone Mar 18, 2019
urde-graven pushed a commit to urde-graven/crystal that referenced this pull request Mar 20, 2019
Merge branch 'master' of github.com:crystal-lang/crystal
cae4845 
* 'master' of github.com:crystal-lang/crystal:
  Change the font-weight used in Playground (crystal-lang#7552)
  Fix formatting absolute paths (crystal-lang#7560)
  Refactor IO::Syscall as IO::Evented (crystal-lang#7505)
  YAML: fix test checking serialization of slices for libyaml 0.2.2 (crystal-lang#7555)
  Let Array#sort only use `<=>`, and let `<=>` return `nil` for partial comparability (crystal-lang#6611)
  Update `to_s` and `inspect` to have similar signatures accross the stdlib (crystal-lang#7528)
  Fix restriction of valid type vs free vars (crystal-lang#7536)
  Rewrite macro spec without executing a shell command (crystal-lang#6962)
  Suggest `next` when trying to break from captured block  (crystal-lang#7406)
  Fix GenericClassType vs GenericClassInstanceType restrictions (crystal-lang#7537)
  Add human readable formatting for numbers (crystal-lang#6314)
  Add command and args to execvp error message (crystal-lang#7511)
  Implement Set#add? method (crystal-lang#7495)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdogruyol sdogruyol sdogruyol approved these changes

@bcardiff bcardiff bcardiff approved these changes

Assignees
No one assigned
Labels
kind:refactor topic:tools:playground
Projects
None yet
Milestone
0.28.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Maroo-b @bcardiff @sdogruyol