Implementation: allow to lookup class and module implementations

[makenowjust]

Fixed #4941

Image:

I think it is totally useful, however this implementation cannot work on some corner case. One corner case, method argument restriction:

def foo(x : ‸Foo)
end

foo

It is hard to implement for now. Another corner case, macro argument:

record Foo,
  x : ‸Bar

It is impossible.

---

@faustinoaq Sorry for the late. Is this okay?

[makenowjust]

ping. Could anyone review this?

[bcardiff]

Was there an explicit decision to not resolve to this line instead the Foo? What happens if the alias has a union?

[makenowjust]

@bcardiff Thank you for reviewing!

I fixed crystal tool implementation to lookup alias name without resolve. For example:

foo.cr:

class Foo
end

class Bar
end

alias Baz = Foo | Bar

Baz

$ bin/crystal tool implementation -c foo.cr:9:1 foo.cr
1 implementation found
foo.cr:7:1

Unfortunately this doesn't work:

$ bin/crystal tool implementation -c foo.cr:7:15 foo.cr
no implementations or method call found

I think implementing this is hard for now...

[sdogruyol]

Thank you @makenowjust 👍

[bcardiff]

I was a bit worried about the introduction of target_type in Path it's actually similar to target_const.

Please, create an issue to track the left-over for the lookup from the alias definition.

Thanks!

[faustinoaq]

Hi @makenowjust Yeah, this is a progress, Thank you! 👍