Adds Enumerable#reduce? for when input is empty #7941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Replaces #4828 |
|
Test failure seems unrelated. |
|
I think the branch is based on some old commit. Could you rebase on master? |
Resolves crystal-lang#2155 Signed-off-by: Mike Fiedler <[email protected]>
miketheman
force-pushed
the
miketheman/empty-reduce
branch
from
266733c to
1a34c8f
Compare
|
Rebased. |
bcardiff
approved these changes
Jul 1, 2019
|
I guess this is fine. If we go this route we'll probably need to add |
|
They are already there 🙃 |
asterite
requested changes
Jul 1, 2019
asterite
approved these changes
Jul 1, 2019
dnamsons
pushed a commit
to dnamsons/crystal
that referenced
this pull request
Jan 10, 2020
Resolves crystal-lang#2155 Signed-off-by: Mike Fiedler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2155
Signed-off-by: Mike Fiedler [email protected]