Int#divisible_by? doesn't care about the value being floored. #8045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Potentially the if statement in % might be optimized away, but why force LLVM to optimize something when it isn't necessary?
asterite
approved these changes
Aug 5, 2019
bcardiff
approved these changes
Aug 5, 2019
sdogruyol
approved these changes
Aug 8, 2019
|
Thank you @yxhuvud :) |
dnamsons
pushed a commit
to dnamsons/crystal
that referenced
this pull request
Jan 10, 2020
…l-lang#8045) Potentially the if statement in % might be optimized away, but why force LLVM to optimize something when it isn't necessary?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The if statement in % might be optimized away by LLVM, but why
force an optimization if the code isn't harder to understand when doing the optimized thing?