ARGF Check if read_count is zero #8177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! The spec is too big, it doesn't actually need to read from a file. You just need an IO that doesn't return all of the Slice that you ask it. I'll send a PR later if I have time. |
|
Actually this is fine, I thought there was a better way to mock argf. I don't agree with Thank you! |
asterite
approved these changes
Sep 13, 2019
asterite
added
kind:bug
dnamsons
pushed a commit
to dnamsons/crystal
that referenced
this pull request
Jan 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8136
\cc @asterite Not too sure about the what the bug was, so I kinda just guessed on the
itblock text. So I can update it to some more accurate if its totally wrong, or if there's a better way to handle the spec?