Fix compile on win32 #8195
Merged
Fix compile on win32 #8195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
added
kind:bug
bcardiff
reviewed
Sep 17, 2019
| Fiber.unsafe_each do |fiber| | ||
| fiber.push_gc_roots unless fiber.running? | ||
| end | ||
| {% unless flag?(:win32) %} |
There was a problem hiding this comment.
I don't understand the reason for this change.
The GC in windows still needs to push the gc root, and the extensions are already behind preview_mt.
There was a problem hiding this comment.
Master fails to compiler because Fiber is not yet implemented on win32. It is only added in #7995
There was a problem hiding this comment.
This is only temporary and will be removed in #7995. But it's necessary to run the specs prior to that.
bcardiff
reviewed
Sep 17, 2019
| # (IO stuff, sleep, etc.). Without it the user might wait more than needed | ||
| # after pressing CTRL+C to quit the tests. | ||
| Fiber.yield | ||
| {% unless flag?(:win32) %} |
There was a problem hiding this comment.
I guess this is because Fiber.yield is not allowed in windows. If so, then maybe is better to add the flag?(:win32) check inside Fiber.yield
There was a problem hiding this comment.
Fiber itself is currently undefined in win32.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies the arithmetic operator change to win32-specific implementation and moves references to
Fiberbehind a flag. The latter can be removed after #7995, but right now it is required to build specs on win32.