Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix : Channel can send successfully but raise #8284

Merged
merged 1 commit into from
Oct 8, 2019
Merged

Fix : Channel can send successfully but raise #8284

merged 1 commit into from
Oct 8, 2019

Conversation

firejox
Copy link
Contributor

@firejox firejox commented Oct 7, 2019

refer to #8269
It uses additional state to track whether the send is successful. If not, it will raise error.

@firejox firejox changed the title Fix : Channel can send successfully without raise Fix : Channel can send successfully but raise Oct 7, 2019
@bcardiff bcardiff added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:concurrency labels Oct 7, 2019
@bcardiff bcardiff added this to the 0.32.0 milestone Oct 7, 2019
bcardiff
bcardiff approved these changes Oct 7, 2019
View reviewed changes
Copy link
Member

@bcardiff bcardiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Last week I was also dealing with the asymmetry of receive & send regarding the delivery state.

@bcardiff bcardiff requested a review from waj October 7, 2019 13:04
Sija
Sija reviewed Oct 7, 2019
View reviewed changes
@firejox firejox force-pushed the fix-inconsistency-channel-send branch from 4cd4278 to b76b1fb Compare October 8, 2019 03:06
@bcardiff bcardiff force-pushed the fix-inconsistency-channel-send branch from b76b1fb to 35148e2 Compare October 8, 2019 13:54
@bcardiff
Copy link
Member

bcardiff commented Oct 8, 2019

@firejox I will rebase this over master so the test_preview_mt can build

@bcardiff bcardiff merged commit 49e67de into crystal-lang:master Oct 8, 2019
@firejox firejox deleted the fix-inconsistency-channel-send branch October 8, 2019 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sija Sija Sija left review comments

@bcardiff bcardiff bcardiff approved these changes

@waj waj waj approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:concurrency
Projects
None yet
Milestone
0.32.0
Development

Successfully merging this pull request may close these issues.
4 participants
@firejox @bcardiff @Sija @waj