Fix % and remainder of min int value against -1
#8321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asterite
added
kind:bug
wooster0
reviewed
Oct 13, 2019
yxhuvud
reviewed
Oct 14, 2019
| {% begin %} | ||
| if other == 0 | ||
| raise DivisionByZeroError.new | ||
| elsif self < 0 && self == {{@type}}::MIN && other == -1 |
There was a problem hiding this comment.
What happens for other == -2 ?
There was a problem hiding this comment.
It seems to work fine. It gives 0.
There was a problem hiding this comment.
But the bug mentioned -1 specifically. I'm not sure we need to add specs for -2, -3 or possibly any number that might have a bug.
There was a problem hiding this comment.
IIUC it stresses different path in the code, so it might be worth having a test coverage for it?
RX14
approved these changes
Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8306