Add missing LLVM::Attribute members

[RX14]

cc @anatol

Applying this patch (or actually a subset of it, only ImmArg needs to be added) should allow building crystal for LLVM 9.

ImmArg is set on some function args by default, it can be ignored, just needs to be mapped correctly so as to not fail.

Fixes #8294.

[asterite]

Nice!

I don't understand: did some enum values change? Does this mean some values work for llvm 8 but for llvm you need other (integer) values for the same enum members? If so, this change should include mapping between these values between versions.

[RX14]

LLVM completely uses the "kind ids" internally, which we query LLVM for at runtime by string literal and store them. The raw enum values are only used for crystal. A look at the llvm bindings and the context for this diff is probaby the best way to grok this.

For reference, here is the LLVM-internal enum IDs for my particular build of LLVM:

{Alignment => 1, AllocSize => 2, AlwaysInline => 3, ArgMemOnly => 4, Builtin => 5, ByVal => 6, Cold => 7, Convergent => 8, Dereferenceable => 9, DereferenceableOrNull => 10, InAlloca => 12, InReg => 13, InaccessibleMemOnly => 14, InaccessibleMemOrArgMemOnly => 15, InlineHint => 16, JumpTable => 17, MinSize => 18, Naked => 19, Nest => 20, NoAlias => 21, NoBuiltin => 22, NoCapture => 23, NoDuplicate => 25, NoFree => 26, NoImplicitFloat => 27, NoInline => 28, NoRecurse => 29, NoRedZone => 30, NoReturn => 31, NoSync => 32, NoUnwind => 33, NonLazyBind => 34, NonNull => 35, OptimizeForSize => 37, OptimizeNone => 38, ReadNone => 39, ReadOnly => 40, Returned => 41, ImmArg => 11, ReturnsTwice => 42, SExt => 43, SafeStack => 44, SanitizeAddress => 45, SanitizeMemory => 48, SanitizeThread => 49, StackAlignment => 53, StackProtect => 54, StackProtectReq => 55, StackProtectStrong => 56, StructRet => 58, SwiftError => 59, SwiftSelf => 60, UWTable => 61, WillReturn => 62, WriteOnly => 63, ZExt => 64}

Notice how some of them are completely out of order, especially ImmArg (which was the "11" in the original error)

[asterite]

Excellent! Thank you for the explanation too.

[bcardiff]

Just tested in osx against llvm@9 👍

[anatol]

It works fine at Arch Linux. Thank you very much @RX14 for the fix.

[RX14]

Note this still isn't the entire set of missing enum members, only the ones that changed between LLVM 8 and 9 which I thought were likely to be culprits. More work could be done on the bindings in the future, this just fixed the immediate fire.