Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Number#round with UInt argument #8361

Merged
merged 2 commits into from
Oct 22, 2019
Merged

Fixed Number#round with UInt argument #8361

merged 2 commits into from
Oct 22, 2019

Conversation

igor-alexandrov
Copy link
Contributor

Changed -digits to digits.abs. Added specs.

Sija
Sija reviewed Oct 22, 2019
View reviewed changes
@igor-alexandrov @Sija
Removed unnecessary brackets
431a368 
Co-Authored-By: Sijawusz Pur Rahnama <[email protected]>
@asterite asterite merged commit 8045bd1 into crystal-lang:master Oct 22, 2019
@straight-shoota
Copy link
Member

Fixed #8360

@straight-shoota straight-shoota changed the title Fixed crystal-lang/crystal/issues/8360 Fixed Number#round with UInt argument Oct 22, 2019
@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:numeric labels Oct 22, 2019
@straight-shoota straight-shoota added this to the 0.32.0 milestone Oct 22, 2019
@igor-alexandrov igor-alexandrov deleted the issue/8360 branch October 23, 2019 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sija Sija Sija left review comments

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:numeric
Projects
None yet
Milestone
0.32.0
Development

Successfully merging this pull request may close these issues.
4 participants
@igor-alexandrov @straight-shoota @Sija @asterite