-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Readline from std-lib #8364
Conversation
It has been extracted to crystal-lang/crystal-readline
While extracting this I also notice that the Maybe instead of:
it should be
So Crystal 0.31.1 users can today add |
/cc #5215 |
It's not that I want to shrink the std-lib, but in the case of readline:
Removing it will allow contributions in a simpler way probably and it is not critical for the std-lib. |
Not sure how much history was in there, but it's a shame we lost the git history. In the future, we could use the following tool (disclaimer, I helped write it) - https://github.com/juliancheal/code-extractor (I also have it as a shell script in a gist here: https://gist.github.com/Fryguy/3490682c7761edeedba1ee28de5ed117) |
The history is very minimal in this case. Like ~10 commits. Usually, I try to keep the repo. |
As an exercise for writing shards (and C-bindings), with @bcardiff we extract the Readline module and create a shard at crystal-lang/crystal-readline.
The v0.1.0 has the same code as in the Crystal std-lib.