New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compiler: notify generic type subtypes, and handle empty subtypes #8417

Merged

asterite merged 1 commit into master from bug/is-a-generic-type

Nov 1, 2019

Member

asterite commented Nov 1, 2019

Fixes #7583
Fixes #8411

Two problems here:

When a generic type was added a new subtype, the new subtype was notified to generic instances but not to the generic type itself
A generic type might end up with no instantiations and so we should also replace it with an "untyped expression" error (which will never be triggered unless there's a bug in the compiler)


          Compiler: notify generic type subtypes, and handle empty subtypes

511f1f1

asterite added kind:bug topic:compiler:semantic labels

bcardiff approved these changes

View reviewed changes

asterite added this to the 0.32.0 milestone

asterite merged commit 975d929 into master

asterite deleted the bug/is-a-generic-type branch

November 1, 2019 19:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind:bug topic:compiler:semantic