Fix GZip Reader and Writer to handle large data sizes #8421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
added
kind:bug
bcardiff
approved these changes
Nov 1, 2019
asterite
approved these changes
Nov 2, 2019
|
I can confirm that this code (manually applied in my environment) fixes my issue (#8418). Amazing work guys, this just confirms that this language is the one I want! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the gzip format isize is 4 bytes wide and contains the size of the original (uncompressed) input
data modulo 2^32. So sizes can be larger than UInt32::MAX but the addition must wrap, not overflow. See https://tools.ietf.org/html/rfc1952#page-8
Fixes #8418