Remove self restriction from Object.from_{json,yaml} #8489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Object.new is not restricted to self, so .from_json and .from_yaml should neither.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Object.new is not restricted to self, so .from_json and .from_yaml should neither.
The generic
Object.newis typically supposed to return a new instance of the respective type. That's the default behaviour. But the method can be overridden by implementing classes.The overloads
.new(JSON::PullParser)and.new(YAML::ParseContext, YAML::Nodes::Node)are not required to return an instance of the type either. There may be valid use cases where the return value is actually a different type./cc #8473 for context