Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Object#in? #8720

Merged
merged 1 commit into from
Jan 28, 2020
Merged

Add Object#in? #8720

merged 1 commit into from
Jan 28, 2020

Conversation

Sija
Copy link
Contributor

@Sija Sija commented Jan 28, 2020

Closes #8671

j8r
j8r reviewed Jan 28, 2020
View reviewed changes
RX14
RX14 reviewed Jan 28, 2020
View reviewed changes
@Sija Sija force-pushed the object-in branch 2 times, most recently from 65ad284 to 5ef498e Compare January 28, 2020 16:35
@RX14 RX14 added this to the 0.33.0 milestone Jan 28, 2020
@RX14 RX14 merged commit 6e907b1 into crystal-lang:master Jan 28, 2020
@straight-shoota
Copy link
Member

Do we really want the splat overload? I agree with @asterite that it's confusing (#8720 (comment)).

@asterite
Copy link
Member

Nevermind, maybe it's good and convenient.

@Sija Sija mentioned this pull request Jan 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asterite asterite asterite left review comments

@straight-shoota straight-shoota straight-shoota left review comments

@jkthorne jkthorne jkthorne left review comments

@j8r j8r j8r left review comments

@bcardiff bcardiff bcardiff approved these changes

@RX14 RX14 RX14 approved these changes

Assignees
No one assigned
Labels
kind:feature topic:stdlib:collection
Projects
None yet
Milestone
0.33.0
Development

Successfully merging this pull request may close these issues.

Object#in?
7 participants
@Sija @straight-shoota @asterite @bcardiff @jkthorne @RX14 @j8r