IO: Set fd to -1 on closed File/Socket #8873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcardiff
added
kind:bug
This is to reduce the chance of reading an outdated fd value
This will force a volatile semantic over the value and prevent using an outdated value across multiple threads.
RX14
approved these changes
Mar 8, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #8733 (comment)
When closing a File or Socket the fd is set to -1 to force an invalid file descriptor on other threads that passed the
check_openassertion before closing it.Atomic is used to force a volatile Java-like semantics so the reads are sequentially consistent with the writes of other threads.