Add String overloads for ljust, rjust and center that take an IO #8923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RX14
approved these changes
Mar 21, 2020
Merged
| @@ -2578,3 +2599,9 @@ describe "String" do | |||
| end | |||
| end | |||
| end | |||
|
|
|||
| private def with_io_memory | |||
There was a problem hiding this comment.
Why did you not just use String.build instead of this helper?
There was a problem hiding this comment.
Oooh... it's a long time since I programmed in Crystal, I forgot this already 😅
There was a problem hiding this comment.
It's my bad, I didn't check the specs well enough!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful to avoid memory allocations, as always.
In particular we could use it in the new Log module to avoid memory allocations at all when logging stuff: https://github.com/crystal-lang/crystal/pull/8847/files#r395989420