Deprecated safeApprove detector #1552
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
We're working to identify OpenZeppelin libs by their hash. Perhaps when that is done we can match on the hash, too, so that we don't have false positives |
|
I think we should build a tool like #1598 to check for outdated dependencies or deprecated functions instead of implementing a detector for each one. This is a really good idea and a direction we should work towards @aviggiano! |
|
By the way @0xalpharush, I was also thinking about creating a detector for ChainLink's deprecated APIs, as many projects fall into that trap. See here code-423n4/2021-06-gro-findings#106 Could we use the same method for those too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request creates a new detector for deprecated
safeApproveusage.Motivation
Although
safeApprovehas been deprecated, many projects still use theSafeERCextension with that function, instead of using the recommended safeIncreaseAllowance and safeDecreaseAllowance, as we can see on reference issues from Code4rena findings on the OpenZeppelin tread.