Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interfacing with environment variables #104

Open
cs-util opened this issue Oct 10, 2023 · 0 comments
Open

Interfacing with environment variables #104

cs-util opened this issue Oct 10, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@cs-util
Copy link
Collaborator

cs-util commented Oct 10, 2023

Provide a simple interface that interacts with environment variables of the system (via EnvironmentV2 so that it can also be overridden for systems/operating systems that do not support the default implementation.
Using these new methods create an IKeyValueStore so that a developer has this as a new option when choosing an IKeyValueStore implementation.
Create a unit test that tests that the new IKeyValueStore is thread safe (might be possible to reuse one of the existing IKeyValueStore tests for this).

I will prepare a draft for this on a new branch that can be continued/completed.
@cs-util cs-util added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Oct 10, 2023
cs-util added a commit that referenced this issue Oct 10, 2023
@cs-util
#104 Added draft for interfacing with environment variables
c909ee9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
cscore Features
Status: To do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cs-util