Simplify references for retrieval #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
butonic
force-pushed
the
simplify-references-for-retrieval
branch
3 times, most recently
from
02b9c2d to
5133cda
Compare
C0rby
force-pushed
the
simplify-references-for-retrieval
branch
2 times, most recently
from
3d99efb to
fef7e6c
Compare
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
C0rby
force-pushed
the
simplify-references-for-retrieval
branch
from
fef7e6c to
fd1c41d
Compare
This was referenced Jun 14, 2021
ishank011
reviewed
Jun 14, 2021
refs
approved these changes
Jun 14, 2021
labkode
reviewed
Jun 14, 2021
|
@ishank011 all updated |
ishank011
approved these changes
Jun 14, 2021
glpatcern
pushed a commit
to cs3org/wopiserver
that referenced
this pull request
Jun 24, 2021
glpatcern
pushed a commit
to cs3org/wopiserver
that referenced
this pull request
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cleaned up version of #126 as a new PR to have them comparable.
Referencewithstorage_id,node_idandpathresource_idbut does change the type. The share implementations need to use ids to prevent breaking references when a path changes.stringPathproperty inResourceInfo