Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify UserId idp should be an origin #159

Closed
wants to merge 1 commit into from
Closed

Clarify UserId idp should be an origin #159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cs3/identity/user/v1beta1/resources.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ import "cs3/types/v1beta1/types.proto";
// A UserId represents a user.
message UserId {
// REQUIRED.
// The identity provider for the user.
// The origin (url without path) of the identity provider for the user, e.g. "https://example.com" or "http://localhost:8080"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about IDPs supporting multiple realms like eg. Keycloak? (see also https://www.keycloak.org/docs/latest/server_admin/#core-concepts-and-terms)

Example:
https://keycloak.owncloud.test/auth/realms/oCIS-realm-1/protocol/openid-connect/...
https://keycloak.owncloud.test/auth/realms/oCIS-realm-2/protocol/openid-connect/...

The realms oCIS-realm-1 and oCIS-realm-2 behave like totally separate IDPs.
Maybe both of them have a user "albert", should they both be treated as the same user in REVA?

I don't think so. Therefore we would need to keep the full URL with path.

string idp = 1;
// REQUIRED.
// the unique identifier for the user in the scope of
Expand Down